Files
lerobot-clone/examples/annotations/run_hf_job.py

123 lines
5.6 KiB
Python
Raw Normal View History

#!/usr/bin/env python
"""Launch ``lerobot-annotate`` on a Hugging Face job (vllm + Qwen3.6-27B VLM).
Spawns one ``h200x2`` job that:
1. installs this branch of ``lerobot`` plus the annotation extras,
2. boots two vllm servers (one per GPU) with Qwen3.6-27B (dense VLM),
3. runs the plan / interjections / vqa modules across the dataset
annotations(steerable): remove Phase 0 canonical vocabulary discovery Drops the optional Phase 0 vocabulary-discovery feature entirely. With the new structured action records (Phase 1a + 1b) providing cross-episode consistency via the deterministic template renderer, the older vocabulary-constraint path is redundant and adds a second constraint mechanism that wasn't well-validated in practice. Removed: * src/lerobot/annotations/steerable_pipeline/vocabulary.py (Vocabulary dataclass + VocabularyDiscoveryModule + load_/ save_vocabulary helpers; canonical_vocabulary.json on-disk format) * src/lerobot/annotations/steerable_pipeline/prompts/module_0_vocabulary.txt (Phase 0 VLM prompt) * tests/annotations/test_vocabulary.py Pruned wiring across: * config.py: VocabularyConfig dataclass + AnnotationPipelineConfig. vocabulary field * executor.py: vocabulary attribute on Executor + _run_vocabulary_ phase method + Phase 0 phases.append call in run() * modules/plan_subtasks_memory.py: Vocabulary import + vocabulary attribute + _subtask_vocabulary_block / _memory_vocabulary_block helpers + _canonicalize_subtask / _normalize / _invalid_subtasks / _build_subtask_retry_message methods + vocabulary-gated retry path in _generate_subtasks + empty-episode warning + _NORMALIZE_ STRIP_TOKENS constant * prompts/module_1_subtasks.txt: {vocabulary_block} placeholder * prompts/module_1_memory.txt: {vocabulary_block} placeholder * __init__.py: Vocabulary / VocabularyDiscoveryModule / load_ vocabulary / save_vocabulary / vocabulary_path / VOCABULARY_ FILENAME re-exports * scripts/lerobot_annotate.py: VocabularyDiscoveryModule import + instantiation + executor argument * examples/annotations/run_hf_job.py: --vocabulary.enabled=false flag + docstring references + inline phase-0 comment The original free-form rephrasings path stays (PlanConfig. n_task_rephrasings still works when task_aug_axes.enabled=False). Action records remain the preferred mechanism for cross-episode subtask consistency. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-02 11:48:05 +02:00
in free-form mode (each episode generates its own subtasks +
memory),
4. uploads the annotated dataset to ``--dest_repo_id`` (when set)
or back to ``--repo_id``.
Usage:
HF_TOKEN=hf_... uv run python examples/annotations/run_hf_job.py
Adjust ``CMD`` below to point at your own dataset / target hub repo.
"""
import os
from huggingface_hub import get_token, run_job
token = os.environ.get("HF_TOKEN") or get_token()
if not token:
review: skip-count fix, atomic writes, dedupe span reconstruction, role guards **#1 Plan-update phase reports correct skip count.** ``_run_plan_update_phase`` only ran ``run_plan_updates`` for episodes with at least one interjection but hardcoded ``episodes_skipped=0``. The summary undercounted skipped episodes. Now returns ``len(records) - processed`` so processed + skipped == total. **#2 ``run_hf_job.py`` installs ``openai``.** The ``CMD`` block does ``pip install --no-deps lerobot[branch]`` then explicitly lists transitive deps. ``openai`` was missing — and since ``VlmConfig.backend`` defaults to ``"openai"``, the job would have ``ImportError``'d when ``vlm_client._make_openai_client`` ran. **#3 Dedupe subtask-span reconstruction.** Module 1's ``_reconstruct_subtasks_from_rows`` (no ``and spans`` guard) and Module 2's ``_read_subtask_spans`` (with the guard) had near- identical logic. Promoted to ``reconstruct_subtask_spans`` in ``reader.py`` using the safer guarded form. Both modules now import the single helper. **#5 Atomic staging.py JSONL writes.** Mirroring the parquet-writer fix from an earlier review round: ``EpisodeStaging.write`` now writes to a sibling ``.tmp`` and ``Path.replace`` atomically. A crash mid-write can no longer leave a half-written JSONL that ``read()`` would then fail to parse. **#6 Atomic ``info.json`` write.** Same pattern in ``executor._ensure_annotation_metadata_in_info`` — ``info.json`` is load-bearing for dataset metadata, so partial writes brick the dataset. **#7 Writer's role-key guard.** ``_normalize_persistent_row`` and ``_normalize_event_row`` accessed ``row["role"]`` directly while every other field used ``.get()``. Pre-validate ``"role" in row`` and raise a friendly ``ValueError`` naming the row, so a future module that accidentally drops ``role`` fails with a triagable message instead of a bare KeyError deep in the writer. **#8 Last subtask span's ``end`` extends to episode end.** ``reconstruct_subtask_spans`` (the new shared helper) takes an optional ``episode_end_t``. When provided, the final span's ``end`` is closed to that timestamp instead of equalling its own ``start`` (zero duration). Both Module 1's plan-update pass and Module 2's interjection anchoring pass ``record.frame_timestamps[-1]``, so downstream "current subtask at refresh_t" lookups no longer miss refreshes that land inside the final span. Sweep: 66 passed, 0 failed. Pre-commit clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-08 12:18:09 +02:00
raise RuntimeError("No HF token. Run `huggingface-cli login` or `export HF_TOKEN=hf_...`")
CMD = (
"apt-get update -qq && apt-get install -y -qq git ffmpeg && "
"pip install --no-deps "
"'lerobot @ git+https://github.com/huggingface/lerobot.git@feat/language-annotation-pipeline' && "
"pip install --upgrade-strategy only-if-needed "
"datasets pyarrow av jsonlines draccus gymnasium torchcodec mergedeep pyyaml-include toml typing-inspect "
"openai && "
"export VLLM_MEMORY_PROFILER_ESTIMATE_CUDAGRAPHS=0 && "
"export VLLM_VIDEO_BACKEND=pyav && "
"lerobot-annotate "
"--repo_id=pepijn223/robocasa_smoke_2atomic_v3 "
"--dest_repo_id=pepijn223/robocasa_smoke_2atomic_v3_ann "
"--push_to_hub=true "
"--vlm.backend=openai "
"--vlm.model_id=Qwen/Qwen3.6-27B "
"--vlm.parallel_servers=2 "
"--vlm.num_gpus=2 "
'--vlm.serve_command="vllm serve Qwen/Qwen3.6-27B '
"--tensor-parallel-size 1 --max-model-len 32768 "
'--gpu-memory-utilization 0.8 --uvicorn-log-level warning --port {port}" '
"--vlm.serve_ready_timeout_s=1800 "
"--vlm.client_concurrency=128 "
"--vlm.max_new_tokens=512 "
"--vlm.temperature=0.7 "
"--executor.episode_parallelism=16 "
"--vlm.chat_template_kwargs='{\"enable_thinking\": false}' "
"--vlm.camera_key=observation.images.robot0_agentview_right "
fix(annotate): stop action records + augmentation from corrupting RoboCasa labels Three compounding bugs made RoboCasa annotation produce off-task subtasks ('move stove to stove with left arm') and drifting augmentations ('wander around the kitchen' for 'Navigate to the stove'). 1. action_records.replace_subtask_text now defaults False. Overwriting the VLM's subtask text with a reconstruction of hallucinated {verb,object,arm,grasp,dest} fields is high-risk: navigation / non-manipulation tasks don't fit the schema and render to nonsense. Records are now additive by default (emit_record_row), never silently replacing subtask text. Flip replace_subtask_text on only for manipulation datasets verified to render cleanly. 2. _render_action_record_to_subtask_text drops a degenerate destination that just echoes the object (verb=move object=stove destination=stove -> 'move stove' instead of 'move stove to stove'). Also routes 'navigate' through the 'to <dest>' preposition family. 3. module_1_task_aug_axes.txt hardened: variants MUST preserve the goal/destination. Explicitly forbids 'Navigate to the stove' -> 'wander around the kitchen'. Only wording / arm / orientation / grasp may vary; verb meaning, object, and destination are fixed. examples/annotations/run_hf_job.py — corrected for RoboCasa: * derive_task_from_video=off (was =always). The dataset task string is authoritative and is what eval conditions on; =always threw it away, re-derived a hallucinated task from the video, and poisoned every downstream subtask/plan row. THIS was the dominant cause. * n_task_rephrasings=0 + task_aug_axes left off — RoboCasa eval uses exact task strings, so augmentation is unused/harmful. * action_records left off — manipulation schema doesn't fit atomic / navigation tasks. * plan_max_steps=6 to keep atomic-task decomposition tight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-02 14:34:48 +02:00
# Phase 1 — plan module (subtasks + plan + memory).
2026-06-02 15:08:25 +02:00
# Embed decoded frames directly (use_video_url=false) rather than
# handing the server a file:// clip. The embedded path is more
# reliable: if clip extraction ever fails, the video_url path would
# silently send NO video and the VLM would hallucinate subtasks from
# the task text alone.
#
# CONTEXT BUDGET: with embedded frames, each frame is ~250-320 vision
# tokens. The model's context is 32768 (see --max-model-len). 32
# frames sampled uniformly across the episode (~8-10k tokens) fits
# comfortably alongside the prompt and the describe/verify passes.
# Do NOT raise max_video_frames toward 128 with embedded frames — that
# is ~33-39k tokens and overflows the context (BadRequestError 400,
# "Input length exceeds maximum context length").
2026-06-02 15:08:25 +02:00
"--plan.use_video_url=false "
"--plan.frames_per_second=1.0 "
"--plan.max_video_frames=32 "
annotate: windowed subtask generation for constant temporal density Long episodes no longer get sparse subtasks. Previously a long episode was subsampled to max_video_frames=32 across its whole duration (~1 frame/4s for a 2-min clip). New opt-in windowing keeps a CONSTANT frames_per_second density by splitting the episode into fixed-length windows and running the subtask chain per window. New PlanConfig.subtask_window_seconds (default 0.0 = off). When > 0 and the episode is longer than one window: * episode is split into consecutive [w0, w1] windows of this length * each window's frames are sampled at frames_per_second (so a 32s window at 1 fps = 32 frames, filling but not exceeding the per-call context budget) * the full describe -> segment -> verify chain runs PER window, in window-relative time [0, L]; spans are offset back to absolute * all windows' spans are merged, frame-snap-deduped, and stitched into one contiguous whole-episode cover Implementation: * _episode_video_block / _video_message / _describe_episode / _verify_subtasks gain an optional window=(w0,w1); when set they embed frames sampled in that absolute range at frames_per_second (video_url path skipped — it's whole-episode). * _clean_spans gains bounds= (override clamp range, for window-relative spans) and dedupe= (skip frame-snap until the merged absolute set). * new _generate_subtasks_windowed + _subtasks_for_window orchestrate the loop; _generate_subtasks branches to them when window_s > 0. run_hf_job.py: --plan.subtask_window_seconds=32 (32s windows at 1 fps). Cost scales with episode length (chain calls × ceil(duration/window)). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-02 16:26:14 +02:00
# Constant 1 fps density via windowing: episodes longer than 32s are
# split into 32-second windows (each 32 frames @ 1 fps, fits context),
# so long episodes get MORE subtasks instead of a sparser whole-episode
# view. describe->segment->verify runs per window; spans are merged +
# stitched to a contiguous whole-episode cover. 0 disables.
"--plan.subtask_window_seconds=32 "
fix(annotate): stop action records + augmentation from corrupting RoboCasa labels Three compounding bugs made RoboCasa annotation produce off-task subtasks ('move stove to stove with left arm') and drifting augmentations ('wander around the kitchen' for 'Navigate to the stove'). 1. action_records.replace_subtask_text now defaults False. Overwriting the VLM's subtask text with a reconstruction of hallucinated {verb,object,arm,grasp,dest} fields is high-risk: navigation / non-manipulation tasks don't fit the schema and render to nonsense. Records are now additive by default (emit_record_row), never silently replacing subtask text. Flip replace_subtask_text on only for manipulation datasets verified to render cleanly. 2. _render_action_record_to_subtask_text drops a degenerate destination that just echoes the object (verb=move object=stove destination=stove -> 'move stove' instead of 'move stove to stove'). Also routes 'navigate' through the 'to <dest>' preposition family. 3. module_1_task_aug_axes.txt hardened: variants MUST preserve the goal/destination. Explicitly forbids 'Navigate to the stove' -> 'wander around the kitchen'. Only wording / arm / orientation / grasp may vary; verb meaning, object, and destination are fixed. examples/annotations/run_hf_job.py — corrected for RoboCasa: * derive_task_from_video=off (was =always). The dataset task string is authoritative and is what eval conditions on; =always threw it away, re-derived a hallucinated task from the video, and poisoned every downstream subtask/plan row. THIS was the dominant cause. * n_task_rephrasings=0 + task_aug_axes left off — RoboCasa eval uses exact task strings, so augmentation is unused/harmful. * action_records left off — manipulation schema doesn't fit atomic / navigation tasks. * plan_max_steps=6 to keep atomic-task decomposition tight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-02 14:34:48 +02:00
# IMPORTANT for RoboCasa: the dataset's task string ("Navigate to the
# stove", "Pick the mug...") is authoritative and is what eval uses.
# ``derive_task_from_video=off`` keeps that canonical task driving
# subtask generation. Do NOT use ``always`` here — it throws the real
# task away, asks the VLM "what is this video about?" with no hint,
# and the hallucinated task then poisons every subtask + plan row.
"--plan.derive_task_from_video=off "
# NO task augmentation for RoboCasa: eval conditions on the exact task
# strings, so synthetic rephrasings are unused at best and (when they
# drift, e.g. "wander around the kitchen") harmful. 0 rephrasings +
# axes disabled = the policy only ever sees the canonical task.
"--plan.n_task_rephrasings=0 "
# action_records OFF: the structured {verb,object,arm,grasp,dest}
# schema is a manipulation schema; RoboCasa navigation / atomic tasks
# don't fit it and the VLM hallucinates. When on, records are purely
# additive (emitted as style="action_record" rows) and never touch
# the subtask text — useful only for long composite manipulation
# tasks. Leave off for RoboCasa atomic / navigation.
fix(annotate): stop action records + augmentation from corrupting RoboCasa labels Three compounding bugs made RoboCasa annotation produce off-task subtasks ('move stove to stove with left arm') and drifting augmentations ('wander around the kitchen' for 'Navigate to the stove'). 1. action_records.replace_subtask_text now defaults False. Overwriting the VLM's subtask text with a reconstruction of hallucinated {verb,object,arm,grasp,dest} fields is high-risk: navigation / non-manipulation tasks don't fit the schema and render to nonsense. Records are now additive by default (emit_record_row), never silently replacing subtask text. Flip replace_subtask_text on only for manipulation datasets verified to render cleanly. 2. _render_action_record_to_subtask_text drops a degenerate destination that just echoes the object (verb=move object=stove destination=stove -> 'move stove' instead of 'move stove to stove'). Also routes 'navigate' through the 'to <dest>' preposition family. 3. module_1_task_aug_axes.txt hardened: variants MUST preserve the goal/destination. Explicitly forbids 'Navigate to the stove' -> 'wander around the kitchen'. Only wording / arm / orientation / grasp may vary; verb meaning, object, and destination are fixed. examples/annotations/run_hf_job.py — corrected for RoboCasa: * derive_task_from_video=off (was =always). The dataset task string is authoritative and is what eval conditions on; =always threw it away, re-derived a hallucinated task from the video, and poisoned every downstream subtask/plan row. THIS was the dominant cause. * n_task_rephrasings=0 + task_aug_axes left off — RoboCasa eval uses exact task strings, so augmentation is unused/harmful. * action_records left off — manipulation schema doesn't fit atomic / navigation tasks. * plan_max_steps=6 to keep atomic-task decomposition tight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-06-02 14:34:48 +02:00
# Keep subtask decomposition tight for atomic tasks:
"--plan.plan_max_steps=6 "
# NOTE: the multi-call subtask quality chain (describe -> segment ->
# verify, 3 VLM calls/episode) is ON BY DEFAULT now. Pass
# --plan.subtask_describe_first=false / --plan.subtask_verify=false to
# disable on datasets you've verified are easy and want fewer calls.
# Phase 2 — interjections + speech.
"--interjections.max_interjections_per_episode=6 "
# Phase 4 — general VQA.
2026-06-02 15:08:25 +02:00
# Ground VQA on the SAME single camera as plan/interjections
# (--vlm.camera_key) instead of iterating every camera. The whole
# pipeline then focuses on one view, e.g. observation.images.base.
"--vqa.restrict_to_default_camera=true "
"--vqa.K=1 "
"--vqa.vqa_emission_hz=1.0"
)
job = run_job(
image="vllm/vllm-openai:latest",
command=["bash", "-c", CMD],
flavor="h200x2",
secrets={"HF_TOKEN": token},
timeout="2h",
)
print(f"Job URL: {job.url}")
print(f"Job ID: {job.id}")